[error_pages] Removing misleading is_granted checker in code example
#9029
Conversation
|
@m4r3x this was indeed a very annoying thing about Symfony security and error pages ... but we fixed it a while ago (symfony/symfony#15953) and we mentioned it here: https://symfony.com/blog/new-in-symfony-2-8-dx-improvements#allow-to-check-for-security-even-in-pages-not-covered-by-firewalls That's why I'm closing without merging, but if I overviewed something, please tell me and we'll reopen. Thanks! |
|
@javiereguiluz Thank you for your reply. Yes - the exception won't be thrown, you are right. However, my point is - it's not possible to use |
|
@m4r3x I see. Then you are right and I was wrong. Re-opening it! |
|
Thank you @m4r3x. |
… code example (Marek Szymeczko) This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #9029). Discussion ---------- [error_pages] Removing misleading `is_granted` checker in code example Docs contain misleading code section that leaves you wondering for a while ;) This commit clearly states that it's no longer possible: https://github.com/symfony/symfony/pull/5325/files Commits ------- 64a996b [error_pages] Removing misleading checker in code example
Docs contain misleading code section that leaves you wondering for a while ;)
This commit clearly states that it's no longer possible:
https://github.com/symfony/symfony/pull/5325/files